Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

docs(dropdown): fix options doc blocks #328

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Conversation

TheAlexLichter
Copy link
Contributor

rename checkbox to dropdown

rename checkbox to dropdown
@TheAlexLichter TheAlexLichter changed the title docs(dropdown): fix options doc blox docs(dropdown): fix options doc blocks Oct 15, 2018
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 once the typo is fixed.

src/components/Dropdown.react.js Outdated Show resolved Hide resolved
@T4rk1n
Copy link
Contributor

T4rk1n commented Oct 15, 2018

Great, thanks.

Copy link
Contributor

@valentijnnieman valentijnnieman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manniL Nice, thanks for contributing!

@T4rk1n Feel free to merge these and other smaller PR's like this if you've reviewed them - I don't think we necessarily need 2 reviewers on small PR's like this.

@T4rk1n
Copy link
Contributor

T4rk1n commented Oct 26, 2018

@valentijnnieman I tagged you because some of those PR's needs a release after merge. I don't know how you want to proceed in those cases. I can merge them and do a PR for the changelogs and release if you want to.

@valentijnnieman
Copy link
Contributor

@T4rk1n That sounds good to me!

@T4rk1n T4rk1n merged commit 716e675 into plotly:master Oct 29, 2018
@T4rk1n T4rk1n mentioned this pull request Oct 29, 2018
@TheAlexLichter TheAlexLichter deleted the patch-1 branch October 29, 2018 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants